Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the issue with multiple pipeline navigation #29

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

HarisudhanRavi
Copy link
Contributor

When we have multiple broadway pipelines, the pipeline graph is not changed based on the selected pipeline menu. But works on reloading the page. The issue is with broadway_dashboard 0.4.0 and phoenix_live_dashboard 0.8.0

broadway_dashboard.mp4

But this works fine with broadway_dashboard 0.3.0 and phoenix_live_dashboard 0.7.0

This is because, in the latest version of broadway_dashboard, the method is not passed as expected with the phoenix_live_dashboard 0.8.0. So by default, phoenix_live_dashboard considers this as patch navigation. But as we don't have any handle_params, it is not navigating.

Since broadway_dashboard 0.3.0 passes redirect to phoenix_live_dashboard, it implements push_redirect(deprecated now) of live_view. Fixed this by passing navigate, as a separate attribute.

This is my first open-source contribution. Correct me on my approach to this. 🙂

lib/broadway_dashboard.ex Outdated Show resolved Hide resolved
Copy link
Contributor

@philss philss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you, @HarisudhanRavi!

This is my first open-source contribution.

Congratulations! 🎉 :D

@philss philss merged commit 4f4c394 into dashbitco:main Jan 9, 2024
2 checks passed
@philss
Copy link
Contributor

philss commented Jan 9, 2024

@HarisudhanRavi this fix is released under version 0.4.1 :)

@HarisudhanRavi
Copy link
Contributor Author

Superb.. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants